JdeRobot / RoboticsAcademy

Learn Robotics with JdeRobot
https://jderobot.github.io/RoboticsAcademy
GNU General Public License v3.0
313 stars 222 forks source link

Cleaning the repo #1975

Closed jmplaza closed 1 year ago

jmplaza commented 1 year ago

Remove unused files, most of them misleading. Many of them come from previous designs and releases, but are not useful anymore.

RajGavadiya7 commented 1 year ago

Sir, I am participating in GSOC 2023, Can I work on this?

jmplaza commented 1 year ago

Hi @RajGavadiya7 ,

there is no need to ask for permission to work on any issue, just submit your Pull-Requests. But in order to make sensible a Pull-Request for this issue long experience with the RoboticsAcademy is required I guess. This is not the best issue for newcomers.

The best way to start contributing to RoboticsAcademy is to get familiar with this software product, just USE RoboticsAcademy, solve and provide feedback about the exercises already available in the current release (FollowLine, ObstacleAvoidance, VacuumCleaner, LocalizedVacuumCleaner...). They use the browser as the only GUI (for source code editing and for exercise monitoring), and a docker image for running the Gazebo simulator (it is named RADI= RoboticsAcademy Docker Image).

pariaspe commented 1 year ago

First PR is ready to merge #1984. It cleans 30 out of 50 exercises.

Exercises cleaned

I've seen some small bugs in several exercises, I'll open a few issues as soon as we merge it. Also, I've seen some broken exercises:

It will be great if you could test them before merging @dvalladaresv @ango1994 @ReyDoran . Thanks. Apart from those exercises, I've done some testing and they should be working. Feel free to also test them.


Pending exercises

*_react exercises will be next

Prototype exercises

Will it be worthy to clean them? There are exercises in other branches related to other ros distributions (mostly ros2 foxy). Again, should we cleaned them?

Not listed in exercises grid neither included in the ddbb

@jmplaza should we remove them?

*_rotors exercises

*_rotors exercises are deprecated since we are not using rotors anymore. Should we remove them ?

ReyDoran commented 1 year ago

I have tested the migrated exercises. All of them seem to be working nicely besides the ones you mentioned. I've also found some minor bugs, I'm opening issues for them, but those were present before the migration. Camera exercises aren't working for me either. Lastly, the exercise called Road Junction is using the id car_junction. The exercise with the id road_junction is the one missing in the db. Its template is using React but it seems it is still being developed.

pariaspe commented 1 year ago

Exercises:

pariaspe commented 1 year ago

Remaining exercises

Industrial Robots

Exercises are prototypes but already in web-templates. So no need to clean them.

Service Robots

Exercises are prototypes and not migrated to web-templates.

Computer Vision

Exercises are prototypes and not migrated to web-templates.

Not Listed

Not migrated to web-templates.

I'm closing this issue. Remaining exercises no need cleaning or are pending to migrate.