Closed jmplaza closed 1 year ago
Sir, I am participating in GSOC 2023, Can I work on this?
Hi @RajGavadiya7 ,
there is no need to ask for permission to work on any issue, just submit your Pull-Requests. But in order to make sensible a Pull-Request for this issue long experience with the RoboticsAcademy is required I guess. This is not the best issue for newcomers.
The best way to start contributing to RoboticsAcademy is to get familiar with this software product, just USE RoboticsAcademy, solve and provide feedback about the exercises already available in the current release (FollowLine, ObstacleAvoidance, VacuumCleaner, LocalizedVacuumCleaner...). They use the browser as the only GUI (for source code editing and for exercise monitoring), and a docker image for running the Gazebo simulator (it is named RADI= RoboticsAcademy Docker Image).
First PR is ready to merge #1984. It cleans 30 out of 50 exercises.
I've seen some small bugs in several exercises, I'll open a few issues as soon as we merge it. Also, I've seen some broken exercises:
Traceback (most recent call last):
File "/usr/lib/python3.8/threading.py", line 932, in _bootstrap_inner
self.run()
File "/usr/lib/python3.8/threading.py", line 870, in run
self._target(*self._args, **self._kwargs)
File "/RoboticsAcademy/exercises/static/exercises/laser_loc/gui.py", line 184, in run
self.gui.update()
File "/RoboticsAcademy/exercises/static/exercises/laser_loc/gui.py", line 78, in update
self.payload["pos_vertices"], self.payload["sonar_sensor"] = self.map.setSonarValues()
File "/RoboticsAcademy/exercises/static/exercises/laser_loc/map.py", line 198, in setSonarValues
hipotenusa = distance/(math.cos(cone/2))
TypeError: unsupported operand type(s) for /: 'list' and 'float'
It will be great if you could test them before merging @dvalladaresv @ango1994 @ReyDoran . Thanks. Apart from those exercises, I've done some testing and they should be working. Feel free to also test them.
Will it be worthy to clean them? There are exercises in other branches related to other ros distributions (mostly ros2 foxy). Again, should we cleaned them?
@jmplaza should we remove them?
*_rotors exercises are deprecated since we are not using rotors anymore. Should we remove them ?
I have tested the migrated exercises. All of them seem to be working nicely besides the ones you mentioned. I've also found some minor bugs, I'm opening issues for them, but those were present before the migration. Camera exercises aren't working for me either. Lastly, the exercise called Road Junction is using the id car_junction. The exercise with the id road_junction is the one missing in the db. Its template is using React but it seems it is still being developed.
Exercises:
Exercises are prototypes but already in web-templates. So no need to clean them.
Exercises are prototypes and not migrated to web-templates.
Exercises are prototypes and not migrated to web-templates.
Not migrated to web-templates.
I'm closing this issue. Remaining exercises no need cleaning or are pending to migrate.
Remove unused files, most of them misleading. Many of them come from previous designs and releases, but are not useful anymore.