search

JdeRobot / RoboticsApplicationManager

Robotic applications lifecycle management
3 stars 12 forks source link

Unifying launchers #41

Closed pawanw17 closed 1 year ago

pawanw17 commented 1 year ago

The only difference between the two launchers is the command for noVNC

noetic uses noVNC version 1.2.0 which has a script called launch.sh humble uses the latest noVNC in which it uses novnc_proxy

novnc_proxy is not there in noVNC version 1.2. The possible solutions were:

  1. Making conditions in the launchers and using launch.sh or novnc_proxy based on the ros version. (working) OR
  2. Upgrade the noVNC version in noetic and use ROS2 launchers only (working) OR
  3. Deprecate the noVNC version in humble to 1.2.0 (not working)

Option 2 will require changes in the original manager.py used by noetic RADI, which could lead to unexpected breaks, hence avoiding it.

MUST be merged with https://github.com/JdeRobot/RoboticsAcademy/pull/2144

jmplaza commented 1 year ago

Hi @pawanw17 , recently @ReyDoran introduced the ROS-release autodetection feature in the RAM. Maybe we should go with Option1. That feature was intentionally introduced to deal with the subtle differences in ROS1 launching and ROS2 launching

pawanw17 commented 1 year ago

yes @jmplaza, I have used parts of @ReyDoran 's autodetection

Here: https://github.com/JdeRobot/RoboticsApplicationManager/blob/fbf04747737e0154b28f64b11843b1b880fb0086/manager/manager/vnc/vnc_server.py#L44