ROS2 launcher no setting the environment on runtime

JdeRobot / RoboticsApplicationManager

Robotic applications lifecycle management

6 stars 11 forks source link

ROS2 launcher no setting the environment on runtime #50

Open pariaspe opened 1 year ago

pariaspe commented 1 year ago

If the ROS 2 environment is well built, this lines won't be needed: https://github.com/JdeRobot/RoboticsApplicationManager/blob/cdc7a5f72fc2b881f6e10d1d74f64c6a671312a1/manager/manager/launcher/launcher_ros2_api.py#L60-L67

OscarMrZ commented 9 months ago

This is solved in the last versions. I think this was not merged due to working in different branches right?

pariaspe commented 9 months ago

When the PR was created envvars were still needed and we were waiting for some changes in the RoboticsInfrastructure repo. I believe this changes were made last December but I am not sure about the current status

OscarMrZ commented 9 months ago

Okey, then it is now definitely merged. I checked and the changes are merged in superthin-dev branch, could you check it?