search

JdeRobot / VisualCircuit

Visual programming of robots using hardware blocks composition and Python
https://jderobot.github.io/VisualCircuit/
13 stars 14 forks source link

Update comparison from '!=' to 'is not' within MotorDriverROS2 block #279

Closed BkPankaj closed 7 months ago

BkPankaj commented 7 months ago

Changes Made

Changed comparison from '!=' to 'is not' for velocities in MotorDriverROS2 block. Additionally, confirmed that the issue with '!=' only occurs in MotorDriverROS2 block, not in other blocks.

Related Issues

Fixes: #278

Screenshots

Updated internal MotorDriverROS2 block in Canvas to use 'is not' comparison screenshot

Screenshot of build output (with modified array print for visualization purposes)

toshan-luktuke commented 7 months ago

I was not able to reproduce this, but its better to use is not for None checks anyways so merging