JdeRobot / VisualStates

Tool for visual programming of robots using automata
https://jderobot.github.io/VisualStates/
GNU General Public License v3.0
8 stars 8 forks source link

Inputs where Integers are to be used, crash when supplied other data types #116

Closed sudo-panda closed 5 years ago

sudo-panda commented 5 years ago

Examples,

sudo-panda commented 5 years ago

I would like to work on this issue.

sudo-panda commented 5 years ago

Can I add support for using parameters in Temporal Transition Code, or should I do that in another pull request.

okanasik commented 5 years ago

I think it is better to add this feature as part of parameterization project. It is not directly related with this issue.

sudo-panda commented 5 years ago

I solved it on the colab repo but I am unable to create a pull request due it not being a fork. Any ideas?

okanasik commented 5 years ago

I have written a method on the hangouts, did you try that?

you should have a fork of the visualstates as your personal repository then you should add this as another remote repository to your local-colab repository then you should push your branch that you would like to create pull request from to that forked remote repo finally through github ui you can create pull request from your personal repo I do not know any other way that you can create a pull request

Also do not forget that before working on any single issue, you should checkout the master branch. pull the latest version from the remote repo. create a new branch for the issue/feature make your changes and push your changes to the remote repo. finally create a pull request.

If you still have problems please let me know.

sudo-panda commented 5 years ago

Sorry I didn't get the notification for the message. I will try that method and if I get merge conflicts while trying pull from the remote repo should I solve it and commit or it is considered a bad practice.

okanasik commented 5 years ago

If you need to merge because of a conflict that is not related to current changes that you have build for the respective issue, it would be bad practice. However, if you need to merge because your changes overwrites the changes done between your last pull and this pull, it is fine. Also do not hesitate to break things, we can always fix things in git :)

sudo-panda commented 5 years ago

Alright, thanks

okanasik commented 5 years ago

fixed by #126