search

JdeRobot / VisualStates

Tool for visual programming of robots using automata
https://jderobot.github.io/VisualStates/
GNU General Public License v3.0
8 stars 8 forks source link

XML validation #117

Closed sudo-panda closed 5 years ago

sudo-panda commented 5 years ago

For Example, If we save a VisualStates file which empty conditional transition code it saves but when opening or importing the file it crashes the program throwing an IndexError Exception.

Wherever the inputs can be empty we need to catch the error, in others we need to validate user inputs to check that they aren't empty.

okanasik commented 5 years ago

I have changed the title of the issue as "XML Validation" because, we should have well-defined XML schema and make sure that XML parsing and creation conforms these norms. In the case of errors, it should be failsafe. However, it should not work by getting everything in try and except clauses.

sudo-panda commented 5 years ago

I would like to work on this issue.

okanasik commented 5 years ago

Partially fixed by #128. We need to have complete XML validation. For example, if a user selects any irrelevant XML document to open in the app, the app should show an error message and should not crash.

sudo-panda commented 5 years ago

This commit 356c893801c08de3bdd7a2cf55c9f222651cbcea does that @okanasik

okanasik commented 5 years ago

Yes, you are right. Sorry I missed that, but the file is not a valid XML file (i.e. not conforming to the general XML schema) the app crashes. Actually, the XML parser gives an error of type xml.parsers.expat.ExpatError Maybe we can solve this problem by using try catch mechanism to catch only this type errors. What do you think?

sudo-panda commented 5 years ago

Yes that can be implemented.

okanasik commented 5 years ago

Invalid XML file error is handled with the commit 700d24e02427dbad909801c986ee178a34cb44bc