search

JdeRobot / VisualStates

Tool for visual programming of robots using automata
https://jderobot.github.io/VisualStates/
GNU General Public License v3.0
8 stars 8 forks source link

Interface to select states to import #91

Closed pushkalkatara closed 5 years ago

pushkalkatara commented 5 years ago

Currently, using Import functionality, all the states are imported in the developing behavior. In some cases, only some of the selected states are required, hence an interface which display all the states and provides functionality to select one or all states to be imported.

sudo-panda commented 5 years ago

I would like to work on adding this feature.

sudo-panda commented 5 years ago

Does the interface show the visual of transitions with the states or only the state names?

pushkalkatara commented 5 years ago

Hi, @sudo-panda Thanks for approaching the issue, we can start initially just with displaying the states.

sudo-panda commented 5 years ago

Are the state ids always continuous or can there be gaps and do the child states have to have greater state ids than the ones in the upper level?

pushkalkatara commented 5 years ago

Hi @sudo-panda , the child states need not be continuous, also it's not necessary that the child state would have greater state ids compared to the ones in the upper level. The whole procedure works on recursive parsing.

sudo-panda commented 5 years ago

Shouldn't a deleted state delete a destination Transitions along with Origin Transition both during importing and in the main VisualStates window. Right now it only deletes origin Transitions.

pushkalkatara commented 5 years ago

I didn't get you, what do you mean by origin transition or destination transition? I believe a transition points from origin state to a destination state. If we remove a particular state, all the transitions attached to it are automatically removed. But if a transition is removed, both the states connected to it stays in the automata.

On Thu, Apr 18, 2019 at 12:38 AM sudo-panda notifications@github.com wrote:

Shouldn't a deleted state delete a destination Transitions along with Origin Transition both during importing and in the main VisualStates window. Right now it only deletes origin Transitions.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/JdeRobot/VisualStates/issues/91#issuecomment-484222074, or mute the thread https://github.com/notifications/unsubscribe-auth/AUR_NmaMPvtuiNH3J8to4YBa0z0iu8Z-ks5vh3EogaJpZM4baskJ .

sudo-panda commented 5 years ago

That should be the ideal behaviour but right now only the transitions that originate from a state are removed on removal of the state and not the ones that point towards the state

sudo-panda commented 5 years ago

Should I modify the current behaviour?

sudo-panda commented 5 years ago

@pushkalkatara could you please reply so that finish adding this feature.

pushkalkatara commented 5 years ago

Hi @sudo-panda . I was busy with something. I think we would require more discussion over this, it would be better to create a separate issue for it.

sudo-panda commented 5 years ago

No problem. Should I create a pull request to add this feature or first solve that issue?

pushkalkatara commented 5 years ago

Both are unrelated, you can proceed with any of them.

pushkalkatara commented 5 years ago

Developing as part of GSoC 2k19 at https://github.com/TheRoboticsClub/colab-gsoc2019-Baidyanath_Kundu/pulls hence closing the issue.