Jdesk / memcached

Automatically exported from code.google.com/p/memcached
0 stars 0 forks source link

eviction problem after using get command with binary protocol version #16

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
binary protocol version:

get command increments refcount but doesn't decrement after command is
finished. The item cannot be evicted after this.

Works if adding a few lines to reset_cmd_handler function but not sure if
this is 100% fixing refcount problem in binary protocol version

static void reset_cmd_handler(conn *c) {
    if (c->item != NULL) {
        item_remove(c->item);
        c->item = 0;
    }

Original issue reported on code.google.com by victor.k...@sun.com on 12 Feb 2009 at 12:14

GoogleCodeExporter commented 9 years ago

Original comment by victor.k...@sun.com on 13 Feb 2009 at 10:06

GoogleCodeExporter commented 9 years ago
I've actually seen symptoms of this in my own tests.  Should be able to 
reproduce it
as a test case.

Original comment by dsalli...@gmail.com on 13 Feb 2009 at 11:38

GoogleCodeExporter commented 9 years ago
Fixed in 72cb22b0ae7ecc1b536a0e4f4898556aba52e057

Original comment by dsalli...@gmail.com on 14 Feb 2009 at 6:00