search

Jdesk / memcached

Automatically exported from code.google.com/p/memcached
0 stars 0 forks source link

ASCII get could be simplified #81

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
process_get_command declares an array of 201 elements (804 bytes) that we
memset to zero each time we enter the function, and we will also traverse
through the complete array when we leave the function. All this to reduce
the number of times to try to lock the stats. Now that we have a
threadlocal stat this locking is really cheap, so we should make the code
easier to read by removing the memset and the traversal. (this will also
give a performance benefit for single-get and small mgets ;-)

Original issue reported on code.google.com by trond.no...@gmail.com on 24 Aug 2009 at 11:28

GoogleCodeExporter commented 9 years ago 
Proposed patch in http://github.com/trondn/memcached/tree/mget_stat_count

Original comment by trond.no...@gmail.com on 24 Aug 2009 at 11:29

GoogleCodeExporter commented 9 years ago 
Hehe.. I reported the same bug twice :D

Original comment by trond.no...@gmail.com on 10 Sep 2009 at 9:47