Open futurekill opened 10 years ago
Thank you so much! I will take a look this weekend
On Tue, Sep 16, 2014 at 12:23 AM, James Candalino notifications@github.com wrote:
I ported your fine chrome extension to Safari. Take a look and let me know
what you think.
You can merge this Pull Request by running
git pull https://github.com/futurekill/smilealways master
Or view, comment on, or merge it at:
https://github.com/Jdhaimson/smilealways/pull/13 Commit Summary
- Added a filter to account for AWS and updated icons.
- Forgot to add the bundled extension.
File Changes
- A Smile Always.safariextension/Icon-128.png https://github.com/Jdhaimson/smilealways/pull/13/files#diff-0 (0)
- A Smile Always.safariextension/Icon-32.png https://github.com/Jdhaimson/smilealways/pull/13/files#diff-1 (0)
- A Smile Always.safariextension/Icon-48.png https://github.com/Jdhaimson/smilealways/pull/13/files#diff-2 (0)
- A Smile Always.safariextension/Icon-64.png https://github.com/Jdhaimson/smilealways/pull/13/files#diff-3 (0)
- A Smile Always.safariextension/Icon-96.png https://github.com/Jdhaimson/smilealways/pull/13/files#diff-4 (0)
- R Smile Always.safariextension/Info.plist https://github.com/Jdhaimson/smilealways/pull/13/files#diff-5 (20)
- A Smile Always.safariextension/Settings.plist https://github.com/Jdhaimson/smilealways/pull/13/files#diff-6 (5)
- A Smile Always.safariextension/global.html https://github.com/Jdhaimson/smilealways/pull/13/files#diff-7 (55)
- A Smile Always.safariextz https://github.com/Jdhaimson/smilealways/pull/13/files#diff-8 (0)
Patch Links:
- https://github.com/Jdhaimson/smilealways/pull/13.patch
- https://github.com/Jdhaimson/smilealways/pull/13.diff
— Reply to this email directly or view it on GitHub https://github.com/Jdhaimson/smilealways/pull/13.
Josh Haimson Massachusetts Institute of Technology 2016 Departments of Computer Science and Biology josh-haimson.com | jhaimson@mit.edu JHaimson@mit.edu
No problem :)
For some reason your fork doesn't seem to have an issues page @futurekill , so it seems the only way to contact you is here. I tried your fork's Safari extension, but the problem is it immediately redirects to smile whenever amazon shows up in the search box suggestions, meaning when it's enabled I can't type anything starting with "a" in the search box without being immediately redirected to smile.amazon.com! Is this fixable?
I ported your fine chrome extension to Safari. Take a look and let me know what you think.