Jdhaimson / smilealways

Chrome Extension to redirect www.amazon.com to smile.amazon.com
www.smilealways.io
GNU General Public License v2.0
145 stars 32 forks source link

Breaks Cloud Player #2

Closed otac0n closed 10 years ago

otac0n commented 10 years ago

This extension causes Amazon Cloud Player to show a message saying "Your connection has limited or no connectivity."

Also, the Sign Out link is broken.

KurtPreston commented 10 years ago

+1

KurtPreston commented 10 years ago

The Cloud Player itself is at URL:

https://www.amazon.com/gp/dmusic/mp3/player

However, I think it's some JSON calls that are breaking that are being made to

https://www.amazon.com/cirrus/

Would it be possible to just exclude these URLs?

Jdhaimson commented 10 years ago

Yeah, that should be easy enough to do. I'll take a shot at it when I get some free time this weekend.

Thanks for letting me know!

Cheers, Josh

On Wed, Apr 2, 2014 at 1:22 PM, Kurt Preston notifications@github.comwrote:

The Cloud Player itself is at URL:

https://www.amazon.com/gp/dmusic/mp3/player

However, I think it's some JSON calls that are breaking that are being made to

https://www.amazon.com/cirrus/

Would it be possible to just exclude these URLs?

Reply to this email directly or view it on GitHubhttps://github.com/Jdhaimson/smilealways/issues/2#issuecomment-39358198 .

Josh Haimson Massachusetts Institute of Technology 2016 Departments of Computer Science and Biology josh-haimson.com | jhaimson@mit.edu JHaimson@mit.edu

devd commented 10 years ago

One simple fix could be to limit the request listener to only frame navigations. I added (by mistake) code to do this in pull request 3. https://github.com/Jdhaimson/smilealways/pull/3/

Jdhaimson commented 10 years ago

Seems to be working for me with the last update to .82. @KurtPreston and @otac0n can you confirm that this issue is now fixed for you as well?

otac0n commented 10 years ago

Seems to be working here as well. :+1:

KurtPreston commented 10 years ago

Sweet, thanks!