Jdhaimson / smilealways

Chrome Extension to redirect www.amazon.com to smile.amazon.com
www.smilealways.io
GNU General Public License v2.0
146 stars 32 forks source link

Warnings due to Conflict with HTTPS Everywhere #37

Closed Soundvessel closed 7 years ago

Soundvessel commented 7 years ago

I love your plugin but it occasionally throws warnings because of a conflict with the HTTPS Everywhere extension by the EFF https://www.eff.org/https-everywhere. Is it possible to make them play nicely together?

This extension failed to redirect a network request to http://smile.amazon.com/o/ASIN/1909263079/sciencefriday/?sa-no-redirect=1 because another extension (HTTPS Everywhere) redirected it to https://www.amazon.com/o/ASIN/1909263079/sciencefriday/.

Piccirello commented 7 years ago

The Chrome web store still has version 0.91, whereas the HTTPS Everywhere fix is in 0.92. @Jdhaimson, can you please update the web store's version?

tastyratz commented 7 years ago

Another vote for that here. This has been driving me nuts for a long time. I had no idea it's been fixed!!

This is married to the HTTPSE issue here: https://github.com/EFForg/https-everywhere/issues/6034

Piccirello commented 7 years ago

Can someone provide insight into why this was closed? The version on the web store is still 0.91.

delitzer commented 7 years ago

Yes, I closed it when I pushed 0.92 to the Chrome Web Store a couple hours ago. The new version is undergoing review but will be live in the store soon.

On Fri, Mar 31, 2017 at 3:22 PM, Tom Piccirello notifications@github.com wrote:

Can someone provide insight into why this was closed? The version on the web store is still 0.91.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/Jdhaimson/smilealways/issues/37#issuecomment-290845997, or mute the thread https://github.com/notifications/unsubscribe-auth/AEMLEPPjcCnF1AwxivP-qkOBXzA9CQcuks5rrXy-gaJpZM4MRUc9 .

Piccirello commented 7 years ago

Excellent, thank you!