search

Jdharden / google-refine

Automatically exported from code.google.com/p/google-refine
Other
0 stars 0 forks source link

Renaming Cells with Ctrl-Enter produced ERROR #45

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. running in netbeans
2. using Ctrl-Enter with Edit cell view to rename 'Drug" cells with same 
string.
3. Error resulted after renaming about 4 or 5 rows 

What do you see instead?

12:57:23.194 [         gridworks_server] Starting Server bound to 
'127.0.0.1:3333' (0ms)
12:57:23.212 [         gridworks_server] Initializing context: '/' from 
'C:\Users\tguidry\Documents\NetBeansProjects\trunk798\trunk\src\main\webapp
' (18ms)
12:57:23.261 [         gridworks_server] Starting autoreloading scanner...  
(49ms)
12:57:23.854 [          project_manager] Failed to use jdatapath to detect 
user data path: resorting to environment variables (593ms)
12:57:23.857 [          project_manager] Using workspace directory: 
C:\Users\tguidry\AppData\Roaming\Gridworks (3ms)
12:57:23.858 [          project_manager] Loading workspace: 
C:\Users\tguidry\AppData\Roaming\Gridworks\workspace.json (1ms)
13:02:00.891 [                  project] Loaded project 1455288364717 from 
disk in 0 sec(s) (277033ms)
13:02:23.934 [          project_manager] Saved workspace (23043ms)
13:03:24.211 [ compute-clusters_command] computed clusters 
[binning,fingerprint] in 75ms (60277ms)
13:03:29.420 [ compute-clusters_command] computed clusters [binning,ngram-
fingerprint] in 35ms (5209ms)
13:03:40.082 [ compute-clusters_command] computed clusters [binning,ngram-
fingerprint] in 18ms (10662ms)
13:07:23.939 [          project_manager] Saving some modified projects ... 
(223857ms)
13:07:23.977 [                  project] Saved project '1455288364717' 
(38ms)
13:07:23.994 [          project_manager] Saved workspace (17ms)
13:11:08.617 [          org.mortbay.log] /command/get-history (224623ms)
java.util.ConcurrentModificationException
        at 
java.util.AbstractList$Itr.checkForComodification(AbstractList.java:372)
        at java.util.AbstractList$Itr.next(AbstractList.java:343)
        at com.metaweb.gridworks.history.History.write(History.java:223)
        at 
com.metaweb.gridworks.commands.Command.respondJSON(Command.java:204)
        at 
com.metaweb.gridworks.commands.Command.respondJSON(Command.java:191)
        at 
com.metaweb.gridworks.commands.history.GetHistoryCommand.doGet(GetHistoryCo
mmand.java:21)
        at 
com.metaweb.gridworks.GridworksServlet.doGet(GridworksServlet.java:211)
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
        at 
org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:511)
        at 
org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:390)
        at 
org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216)
        at 
org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182)
        at 
org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:765)
        at 
org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:418)
        at 
org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
        at org.mortbay.jetty.Server.handle(Server.java:326)
        at 
org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:542)
        at 
org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnecti
on.java:923)
        at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:547)
        at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:212)
        at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:404)
        at 
org.mortbay.jetty.bio.SocketConnector$Connection.run(SocketConnector.java:2
28)
        at 
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.j
ava:886)
        at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:
908)
        at java.lang.Thread.run(Thread.java:619)
13:12:23.994 [          project_manager] Saving some modified projects ... 
(75377ms)
13:12:24.099 [                  project] Saved project '1455288364717' 
(105ms)
13:12:24.131 [          project_manager] Saved workspace (32ms)

Original issue reported on code.google.com by thadguidry on 17 May 2010 at 6:18

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by thadguidry on 17 May 2010 at 6:43

Attachments:

GoogleCodeExporter commented 9 years ago 
Presumably fixed by r809, by sprinkling in a few "synchronized". Concurrency 
bugs are hard to test.

Original comment by dfhu...@gmail.com on 18 May 2010 at 12:03

GoogleCodeExporter commented 9 years ago 
Ugh.  I'm not saying it's not fixed, but the "sprinkling" wording makes me 
profoundly 
uncomfortable.  The thing that makes our current antiquated concurrency models 
so 
difficult is that they require expert analysis.  "Sprinkling" may fix it or it 
just 
may just slow irrelevant operations down while not protecting the critical ones.

But perhaps I'm reading too much into the wording...

Original comment by tfmorris on 18 May 2010 at 1:46

GoogleCodeExporter commented 9 years ago 
Not fixed.

Click Edit on cell "Dallas" and rename to "ticktock".
Then tap CTRL-ENTER and cells update.
Click Edit on different cell "Richardson" and rename to "yoyo".
Then tap CTRL-ENTER and cells update, but "Dallas" cells re-appear as well.

Original comment by thadguidry on 18 May 2010 at 2:08

GoogleCodeExporter commented 9 years ago 
Tfmorris, excuse my language. I meant putting synchronized on public methods so 
to ensure that the object is 
always accessed in a coherent state.

Thad, that's a different issue that has to do with keystroke handling. 
Apparently somehow the Enter key is fired 
on the Undo link of the previous operation.

Original comment by dfhu...@gmail.com on 18 May 2010 at 2:26

GoogleCodeExporter commented 9 years ago 
Fixed by r812.

Original comment by dfhu...@gmail.com on 18 May 2010 at 2:52

GoogleCodeExporter commented 9 years ago

Original comment by tfmorris on 18 Sep 2012 at 2:21

GoogleCodeExporter commented 9 years ago

Original comment by tfmorris on 18 Sep 2012 at 2:56