search

JeLLyNinjas / TerminalFighter

5 stars 2 forks source link

Cleaned variable names for targetting terminal class #28

Closed gordon-cheung closed 9 years ago

bseto commented 9 years ago

I like the new names better than the old ones! good :)

enochtsang commented 9 years ago

They are better overall, the naming has improved, but small things like the consistent use of underscores needs to be improved.

gordon-cheung commented 9 years ago

Pliz Review again

enochtsang commented 9 years ago

Looks good, merge in from master first. Make sure everything is still the same, then we can merge in the pull request.

EDIT: Nevermind looks good, merging.