JeLLyNinjas / TerminalFighter

5 stars 2 forks source link

New not so basic grunt #29

Closed bseto closed 9 years ago

enochtsang commented 9 years ago

I think the different colors for different enemies would be better done as a dict member variable rather than a function. So in the init function:

self.enemy_colors_ = { 'BasicGrunt' = RED,
                       'NotSoBasicGrunt' = WHITE
}
enochtsang commented 9 years ago

screenshot 10 I've gotten this crash after playing a bit. Haven't diagnosed it myself.

enochtsang commented 9 years ago

Lower the speed of this unit please. The word is hard to read with its current speed. Also if you could get them to shoot that'd be good, maybe a weapon delay of 200.

beaesguerra commented 9 years ago

I think that the new_not_so_basic_grunts should also be a different color when in rifle mode (like how basic grunts are red and not so basic grunts are yellow in homing missiles)

beaesguerra commented 9 years ago

Also, in homing missiles, it is hard to see the targeted basic grunt enemies because the enemy and the target border color are both red. Should we change the basic grunt color or the target color in homing missile?

beaesguerra commented 9 years ago

I like how the white text of the not so basic grunts (when using homing missiles) makes it easier to read the tags while they are moving. However, the blue text of the not so basic grunts (when using rifle) is hard to read when the tags are moving. I think it is easier for users to read moving tags when the text is bright. Perhaps making the not so basic grunts yellow when using rifle and making the basic grunts blue when using homing missiles will help.

bseto commented 9 years ago

Seems like a good idea @beaesguerra! :)

enochtsang commented 9 years ago

Overall I didn't like the dark blue color, even for the slow moving targets, so I changed the color of the blue on rifle to be lighter.

beaesguerra commented 9 years ago

Looks good!