search

JeLLyNinjas / TerminalFighter

5 stars 2 forks source link

generalized missiles to projectiles #55

Closed enochtsang closed 8 years ago

enochtsang commented 8 years ago

refactored missile launcher to have projectile listeners instead of explicitly missile listeners

bseto commented 8 years ago

Good idea. However, we need a way for Universe to distinguish between a friendly and enemy projectile when Universe passes the object to the Collision Handler. You mentioned a fix where we could create another listener function where it is like notify_enemy_projectile or notify_friendly_projectile. I think that is a good idea.

Please implement the fix to the above problem, and then we can merge this. Good job and good idea!

enochtsang commented 8 years ago

Instead of notify_enemy... or notify_friendly... I set an argument for the team that the projectile is affiliated with. I think this would provide greater flexibility for us if we wanted to have neutral objects or anything else. Let me know what you think.

bseto commented 8 years ago

I think it looks good. Hopefully everything is setup for you to do your collision handler. Good luck!