JeLLyNinjas / TerminalFighter

5 stars 2 forks source link

Enoch/config #98

Closed enochtsang closed 6 years ago

enochtsang commented 6 years ago

Currently there's no safe way to load in a setting. If you do the path wrong the whole thing crashes. I have plans to add in a safe way to load in settings but I'll put that in another pull request.

Part of this pull request is integrating the settings, i.e. parametrizing things, so I ended up parameterizing things not related to settings as well.

bseto commented 6 years ago

A couple things. You need to provide the Findyaml-cpp.cmake thing, just like how I included "FindSDL2_ttf.cmake".

CMake Error at CMakeLists.txt:13 (find_package):
  By not providing "Findyaml-cpp.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "yaml-cpp",
  but CMake did not find one.

  Could not find a package configuration file provided by "yaml-cpp" with any
  of the following names:

    yaml-cppConfig.cmake
    yaml-cpp-config.cmake

  Add the installation prefix of "yaml-cpp" to CMAKE_PREFIX_PATH or set
  "yaml-cpp_DIR" to a directory containing one of the above files.  If
  "yaml-cpp" provides a separate development package or SDK, be sure it has
  been installed.

-- Configuring incomplete, errors occurred!

Another thing, I don't think you included the directory Settings? so I can't really find settings.cpp