Jean-Baptiste-Camps / stemmatology

Stemmatological Analysis of Textual Traditions
GNU General Public License v3.0
15 stars 3 forks source link

Renaming functions #2

Closed Jean-Baptiste-Camps closed 6 years ago

Jean-Baptiste-Camps commented 7 years ago

Two functions have been renamed,

PCC.elimination > PCC.overconflicting
PCC.doElimination > PCC.elimination

The names now make more sense. We need to:

As to what concerns the classes, they should change too in the following fashion:

pccElimination > pccOverconflicting
Jean-Baptiste-Camps commented 7 years ago

On second thoughts, I wonder if it would not be easier to just integrate the very small PCC.doElimination, in PCC.elimination, and keep every name as is. Apparently, I had left a comment suggesting just that, and, Florian, you seem to think so too.

Jean-Baptiste-Camps commented 7 years ago

On third thoughts, I say: keep it. There are use cases where you want only an estimation of the overconflicting, and you may want to iterate this process with different thresholds, without actually suppressing anything from the database.

Jean-Baptiste-Camps commented 7 years ago

@floriancafiero , are you ok now with all the names, and can I close this ?

floriancafiero commented 6 years ago

Yep, let's close this :)