search

Jean-Baptiste-Camps / stemmatology

Stemmatological Analysis of Textual Traditions
GNU General Public License v3.0
15 stars 3 forks source link

PCC.distribute #6

Open Jean-Baptiste-Camps opened 7 years ago

Jean-Baptiste-Camps commented 7 years ago

I am not sure the use of this function is implemented. It is supposed to serve for the option alternateReadings=TRUE but I do not see it used in the code.

Jean-Baptiste-Camps commented 6 years ago

It is not used, and, after recoding -and removing- a very similar function (expandVL), I realise that it can't really be used for this purpose. e.g., let's take two very simple variant locations:

"1,2" NA
"1,2" NA

Should it create a conflict or not? With the current method, yes, because there is a 'closed' configuration:

{1,2}, {1,1}, {2,1}, {2,2}

But, with a function like distribute or expandVL, there will be no conflict, and the new database will look like::

1 NA
2 NA
1 NA
2 NA

The option to replace that could be to transform the matrix into a list, cf. #37 .