Jean-Tinland / simple-bar

A yabai status bar widget for Übersicht

https://www.jeantinland.com/toolbox/simple-bar

MIT License

1.21k stars 129 forks source link

showNetworkName toggle and small errors in readme #343

Closed Kn4ughty closed 1 year ago

Kn4ughty commented 1 year ago

Readme

I added a missing space I also made it clear what the cmd + t shortcut does.

Network name toggle

I added a toggle in settings for the network widget, that toggles if the name of the network should be shown.

(What it looks like when toggled off)

This fixes #324

Kn4ughty commented 1 year ago

Unfortunately, I dont know how to remove the extra padding on the right.

Kn4ughty commented 1 year ago

Could be better if it was set to the inverse, hideNetworkName instead. might be more understandable to users and would be more clean in the code.

Kn4ughty commented 1 year ago

I updated toggle name to "Hide Network Name":

And variable names are now "hideNetworkName".

Kn4ughty commented 1 year ago

I still dont know how to get rid of the extra padding on the side, but this is at least a base working feature.

Jean-Tinland commented 1 year ago

Thank you very much! I'm merging your work on master. I added the extra padding fix, please let me know if it is working as expected as I couldn't test it.

Kn4ughty commented 1 year ago

I can confirm that your fix works!

Also big fan of how you merged those two lines since they have the same output.

(also if you had any suggestions on how to create better pull requests I would be happy to hear)