search

Jean-Tinland / simple-bar

A yabai status bar widget for Übersicht
https://www.jeantinland.com/toolbox/simple-bar
MIT License
1.21k stars 129 forks source link

Option to disable shadow #379

Closed deusipse closed 11 months ago

deusipse commented 11 months ago

Is your feature request related to a problem? Please describe. There doesn't seem to be an option to turn off the shadow, and I have yabai running with shadows off. (in yabairc) yabai -m config window_shadow off image The shadow can still be seen, and shadows are not present for any other applications. Current available options:

image

Describe the solution you'd like An option to turn off the shadow.

While I'm at it, thanks for making this bar, it is by far the best one I've used for two years now!

Jean-Tinland commented 11 months ago

Hmm that's weird, I just tested disabling and enabling shadow and simple-bar is normally checking on each refresh if yabai has enabled shadow or not by running this command yabai -m config window_shadow. Depending on the output, It removes automatically its shadow.

Can you try to run this command and see if it returns off?

Otherwise, if you want an easy fix, you can simply add these lines in your custom styles tab (in settings):

.simple-bar {
  box-shadow: none !important;
}

Edit: And thank you for your kind words, I appreciate that you find this project useful enough to use it on a daily basis!

deusipse commented 11 months ago
image

Interesting, it says off when I ran the command... Also weirdly enough, the css doesn't make the shadow go away:

image

The shadow is still there. It seems that the box-shadow: none !important; only made the red outline not appear when selecting the bar.

And now I tried updating it to the latest git commit 6abd85084b30fa14673ca189036e6cb8bc1fdf42: the bar doesn't load at all and has this error:

image

My previous install worked and was commit number 3d38feca9418597ba416f6d6f3a0160f2a1182b9. Not sure what's going on, I've never had any issues like this before! I'm using the latest Ubersicht 1.6.82 on Sonama 14.1.

Jean-Tinland commented 11 months ago

Oh, I think I know what is happening. It seems that the shadow you see are not .simple-bar shadows because they are rightly removed. I simply didn't removed all the children shadows and they are projected below the bar. It seems that I didn't handled well the floating variant either.

I just pushed a fix that should make all shadow disappear depending on the yabai config :)

I also tried to fix the error you saw, please let me know if every thing is working fine again.

deusipse commented 11 months ago

Yep - this fixed everything!! Thank you so much for your work and quick response :D