Jean-Tinland
commented
10 months ago Thanks, It was indeed an oversight :)
I made a change to your PR as it seems that this could be handled with CSS only thanks to that fact that you moved the settings outside the .simple-bar__data div. That :empty pseudo-selector is really handful.
By the way you are right there was no style guidelines anywhere so I added some basic guidelines here: https://github.com/Jean-Tinland/simple-bar/blob/master/CONTRIBUTING.md#coding-style-conventions
Edit: typo
Gelio
Description
Problem: When no widgets are enabled, there is still a small rectangle in the bottom right of the screen. The container itself is not hidden even when all widgets are disabled. It looks out of place.
Solution: Hide the container when all widgets are disabled.
Type of change
How Has This Been Tested?
[x] There is no container when all widgets are disabled
[x] The container appears after enabling a widget
Test Configuration:
Checklist:
[ ] My code follows the style guidelines of this project
I am not sure where the style guidelines are located. It passes
yarn lint.[x] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
I don't think it needs comments.
[x] My changes generate no new warnings
Changes to make to the documentation
None.