Jean-Tinland / simple-bar

A yabai status bar widget for Übersicht
https://www.jeantinland.com/toolbox/simple-bar
MIT License
1.21k stars 129 forks source link

Fix google chrome crash when searching on page (cmd+f) #397

Closed tzkoshi closed 6 months ago

tzkoshi commented 6 months ago

Description

In Google Chrome if I open the find window (cmd+f) it crashes the app with "unterminated string" JSON.parse error. I saw that a fix was implemented in earlier versions, following the github issue: https://github.com/Jean-Tinland/simple-bar/issues/93

Fixes # (issue) https://github.com/Jean-Tinland/simple-bar/issues/93

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test Configuration:

Checklist:

Changes to make to the documentation

Please list any changes to the documentation that are required to reflect your changes.

Jean-Tinland commented 6 months ago

Thanks! I simply chained the tr command after the sed one instead of reassigning the windows variable on itself. Please let me know if your fix is still working.