Jean-Tinland / simple-bar

A yabai status bar widget for Übersicht
https://www.jeantinland.com/toolbox/simple-bar
MIT License
1.21k stars 129 forks source link

small fix for skhd mode refresh from server #398

Closed nomppy closed 6 months ago

nomppy commented 6 months ago

Description

Tiny fix for skhd mode indicator

Fixes https://github.com/Jean-Tinland/simple-bar-server/issues/3

How Has This Been Tested?

Mode refreshing now updates correctly

Checklist:

Jean-Tinland commented 6 months ago

Thanks for the fix! Wouldn't be better to trigger the refresh from the outside of simple-bar?

You could do the curl to simple-bar-server just after you triggered the mode change.

This way, the port wouldn't be hardcoded in simple-bar yabai-set-mode-server.sh script.

Please let me know if this would suits you! If so, I'll remove the curl present inside yabai-set-mode-server.sh.

nomppy commented 6 months ago

I agree with you that it is better to trigger the refresh due tot he port. Initially I just copied the structure for the other set-mode.sh.

Jean-Tinland commented 6 months ago

Ok, I merged your PR and removed the internal curl. You can now add the curl to your change mode trigger!

Thank you for your help :)