Jean-Tinland / simple-bar

A yabai status bar widget for Übersicht

https://www.jeantinland.com/toolbox/simple-bar

MIT License

1.21k stars 129 forks source link

Fixing yabaiPath bug. #419

Open toastsandwich opened 1 month ago

toastsandwich commented 1 month ago

Description

Fix for issue #401 This is the bug where yabaiPath is being over ridden, so its separated from the const group.

Type of change

Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
OS version [e.g. Sonoma 14.1.1]
Yabai version [e.g. yabai-v6.0.1] (output of yabai --version)
Übersicht version [e.g. Version 1.6 (82)]

toastsandwich commented 1 month ago

Hey @Jean-Tinland, this pr solves the issue for overriding of yabai path

Jean-Tinland commented 1 month ago

Hi, thanks for your contribution but this will maybe solve this specific problem but it will also remove the ability to change the yabai path from simple-bar settings.

I'm not sure why you need to modify this as the path is customizable from simple-bar settings. This value is simple a default value in case the users completely removes the path in the settings.

toastsandwich commented 1 month ago

Ok so @Jean-Tinland when i had configured simple bar i got the error as "something went wrong..." upon researching there was issue raised regarding the same, and had solution provided, and recently also new issue was opened. So what i am thinking is yabaiPath must be overridden by settings.Global. So by taking it out, it starts working.