search

Jean28518 / linux-assistant

A daily linux helper with powerful integrated search, routines checks and administrative tasks. The Project is built with flutter and python.
https://www.linux-assistant.org
GNU General Public License v3.0
87 stars 12 forks source link

Version reading not working #115

Closed jjk4 closed 1 year ago

jjk4 commented 1 year ago

image Ubuntu 22.04 ...

Nati0ns commented 1 year ago

Hi,

I was thinking: instead of trying to bend and modify the version string so that it will be parsed correctly as a double, why not just change the data type of the version property in the Environment class to string? Is it necessary for the version to be a double?

There were some issues with the version number caused by this parsing operation in the past. Using the version string as is would've likely solved these and may prevent similar issues in the future as well.

Best regards.

jjk4 commented 1 year ago

That would be another option. Maybe it would be good to have both. A string for just showing the version in frontend (that would even be more precise, as we could leave "22.04.5" or the Mint version name) and a double for checking if the version is above/below a specific value. I don't know if this is needed yet, but maybe we need this in the future for features that only work on specific versions.

jjk4 commented 1 year ago

I added this in #116 image