search

JeanChristopheMorinPerso / rez-pip

PyPI/python package ingester/converter for the rez package manager
https://rez-pip.readthedocs.io/en/latest/
Apache License 2.0
23 stars 5 forks source link

rez-pip reinstalls numpy everytime #58

Open JeanChristopheMorinPerso opened 11 months ago

JeanChristopheMorinPerso commented 11 months ago 
(.venv) [jcmorin@arch01 rez-pip]$ REZ_PACKAGES_PATH=~/rez_packages:/tmp/asd rez-pip2 numpy -p /tmp/asd --python-version 3.9
INFO     Installing requested packages for Python 3.9.18                                                                                                                                 
INFO     Resolved 1 dependencies for python 3.9.18                                                                                                                                       
INFO     Downloading...                                                                                                                                                                  
INFO     Downloaded numpy-1.26.0 to '/tmp/rez-pip-targetf1fombqc/wheels/numpy-1.26.0-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl' (18185894 bytes)                          
INFO     Downloaded 1 wheels                                                                                                                                                             
INFO     Installing numpy-1.26.0 wheel                                                                                                                                                   
INFO     Creating rez package for numpy                                                                                                                                                  
INFO     Installing numpy-1.26.0 [platform-linux, arch-x86_64, python-3.9]                                                                                                               
INFO     Created 1 variants and skipped 0

(.venv) [jcmorin@arch01 rez-pip]$ REZ_PACKAGES_PATH=~/rez_packages:/tmp/asd rez-pip2 numpy -p /tmp/asd --python-version 3.9
INFO     Installing requested packages for Python 3.9.18                                                                                                                                 
INFO     Resolved 1 dependencies for python 3.9.18                                                                                                                                       
INFO     Downloading...                                                                                                                                                                  
INFO     Downloaded numpy-1.26.0 to '/tmp/rez-pip-targetxiwjbwt3/wheels/numpy-1.26.0-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl' (18185894 bytes)                          
INFO     Downloaded 1 wheels                                                                                                                                                             
INFO     Installing numpy-1.26.0 wheel                                                                                                                                                   
INFO     Creating rez package for numpy                                                                                                                                                  
INFO     Installing numpy-1.26.0 [platform-linux, arch-x86_64, python-3.9]                                                                                                               
INFO     Created 1 variants and skipped 0

I have no idea why it gets re-installed.

JeanChristopheMorinPerso commented 11 months ago

A little bit more debugging, the description field seems to be the culprit...

diff --git a/existing b/new
--- a/existing
+++ b/new
@@ -1 +1 @@
   - help with outreach and onboard new contributors  - write grant proposals and help with other fundraising efforts  ! For more information about the ways you can contribute to NumPy, 
 -visit [our website](https://numpy.org/contribute/).  If you’re unsure where to start or how your skills fit in, reach out! You can  ask on the mailing list or here, on GitHub, by 
 +visit [our website](https://numpy.org/contribute/).   If you’re unsure where to start or how your skills fit in, reach out! You can  ask on the mailing list or here, on GitHub, by 
  opening a new issue or leaving a  comment on a relevant issue that is already open.

Somehow, sometimes the description isn't correctly written or something like that. Actually, it's either the input description that changes, or rez reformats the string in a weird way in memory just before it's written out, or rez reformats the text in a weird way when it writes it in the package definition file.

So the bug isn't on rez-pip's side.

And obviously, it's inconsistent...