search

JeanChristopheMorinPerso / rez-pip

PyPI/python package ingester/converter for the rez package manager
https://rez-pip.readthedocs.io/en/latest/
Apache License 2.0
23 stars 4 forks source link

fix(cli): add RuntimeError when no python package found #81

Closed MrLixm closed 10 months ago

MrLixm commented 10 months ago

Hello, This is a very simple change that is part of an issue I'm currently investigating on why does rez-pip doesn't work on a system.

Adding the exception make it more explicit there is an issue on the python package side, instead of rez-pip just finishing without outputing anything to stdout which make it tricky to debug.

I do not know the side-effect of raising an exception at this level so let me know if you prefer a "softer" solution.

MrLixm commented 10 months ago

Note that all tests passed on my local Windows machine with python-3.10, note sure what is going on here.

codecov[bot] commented 10 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (8515ee4) 82.14% compared to head (a405bcc) 81.91%.

Files Patch % Lines
src/rez_pip/cli.py 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #81 +/- ## ========================================== - Coverage 82.14% 81.91% -0.23% ========================================== Files 8 8 Lines 717 719 +2 Branches 149 150 +1 ========================================== Hits 589 589 - Misses 113 115 +2 Partials 15 15 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.