search

Jeavon / Slimsy

Effortless Responsive & Lazy Images with LazySizes and Umbraco
MIT License
72 stars 23 forks source link

Umbraco v13 ConvertImgToResponsive methods are broken #74

Closed Jeavon closed 7 months ago

Jeavon commented 8 months ago

Umbraco v13 have changed the objects returned by the RteMacroRenderingValueConverter which breaks how Slimsy works

There is a pending PR to make this possible to fix in a future v13 targeted release https://github.com/umbraco/Umbraco-CMS/pull/15645

mikecp commented 8 months ago

The PR has been merged and should be included in V13.2.0.

Jeavon commented 8 months ago

Thanks Mike!

Jeavon commented 8 months ago

For anyone who can't wait for Umbraco v13.2 we have "hacked" version of Slimsy for Umbraco v13.1.1 on MyGet - https://www.myget.org/feed/umbraco-packages/package/nuget/Our.Umbraco.Slimsy/5.0.0-alpha.487 We will make a proper Slimsy v5 release once Umbraco v13.2 is released.

Jeavon commented 7 months ago

Fixed in v5.0.0