JedWatson / happiness

Standard customised to make me happy
MIT License
124 stars 15 forks source link

Support via linter-js-standard #3

Open developit opened 9 years ago

developit commented 9 years ago

The readme indicates that it is possible to apply happiness rules in Atom via linter-js-standard, but that project doesn't seem to support happiness. I'm guessing this was something the readme just inherited from standard/semistandard, but it's an option that would be lovely to have.

I have submitted a PR to linter-js-standard that adds happiness support here. If you have a second, please look at the changes and let me know if anything strikes you as being incorrect.

Thanks :)

dcousens commented 9 years ago

You are exactly right, that was a copy-over from semistandard.

Awesome PR @developit, I hope it gets merged. Now we just need to get it working in Sublime :)

wesleytodd commented 8 years ago

The referenced PR was merged. @developit is there something we should do on this end, like update the readme? If so, do you want to do that or should I?

developit commented 8 years ago

Feel free, I can barely remember what this was about by now, haha.

wesleytodd commented 8 years ago

Ok, well I tried to install that package, but it was way out of date. So I added a PR for them to update happiness in their package.json and will try again once it is merged. I have been messing around with atom lately, so I will try to actually use it once they update.

EDIT: https://github.com/ricardofbarros/linter-js-standard/pull/86