search

JedWatson / react-component-gulp-tasks

Common Gulp tasks I use across my React Component projects
MIT License
113 stars 42 forks source link

upgrade gulp-git #30

Open kimxogus opened 7 years ago

kimxogus commented 7 years ago

gulp-git has require-dir@0.1.0 as a dependency, and require-dir@0.1.0 will fail with node v8. So I upgraded gulp-git and fixed some code with happiness --fix.

jorrit commented 7 years ago

I hope @JedWatson can merge this PR soon.

blacktemplar commented 7 years ago

didn't see this pull request,

This solves issue #31

paramaggarwal commented 7 years ago

I hope @JedWatson can merge this PR soon.

primaryobjects commented 7 years ago

I can confirm this issue exists after upgrading to node v8.9.0.

Upgrading the version of gulp-git in package.json indeed resolves the issue.

"dependencies": {
  ..
  "gulp-git": "^2.4.1",
}
palashkaria commented 6 years ago

any chance this could get merged @JedWatson ?