search

JedWatson / react-component-gulp-tasks

Common Gulp tasks I use across my React Component projects
MIT License
113 stars 42 forks source link

Problem with node 8 and old require-dir #31

Open blacktemplar opened 7 years ago

blacktemplar commented 7 years ago

The requirement gulp-git uses require-dir 1.0

Since require-dir is broken with the new require from node 8 (this issue got fixed in require-dir 0.3.2) I get the following error:

node_modules/require-dir/index.js:93
            if (!require.extensions.hasOwnProperty(ext)) {
                                    ^

TypeError: require.extensions.hasOwnProperty is not a function
    at requireDir (node_modules/require-dir/index.js:93:37)
    at Object.<anonymous> (node_modules/gulp-git/index.js:4:18)
    at Module._compile (module.js:569:30)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:503:32)
    at tryModuleLoad (module.js:466:12)
    at Module.require (module.js:513:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (tasks/release.js:1:73)

If we update to gulp-git ^2.0.0 we would solve this problem, but I am not sure if this introduces other compatibility problems.