search

JedWatson / react-hammerjs

ReactJS / HammerJS integration. Support touch events in your React app.
MIT License
937 stars 129 forks source link

Migrating from React.PropTypes #67

Closed chadams closed 7 years ago

chadams commented 7 years ago

using prop-types package for newer React version 15.5.0

chadams commented 7 years ago

I went ahead and added both react updates to same branch as they were small

afc163 commented 7 years ago

:+1:

quantizor commented 7 years ago

@JedWatson without these changes, using the component with React >=15.5 emits red console errors that look like hard errors (thanks Facebook 😞); would be great to get this in soon

afc163 commented 7 years ago

ping

derpoho commented 7 years ago

@JedWatson Can you please merge this? Since the React 16 Update is coming soon, this is seriously necessary!

derpoho commented 7 years ago

@chadams Maybe you can implement the suggested changes, then we could use this PR.

paranoidjk commented 7 years ago

@derpoho can you merge this and continue fix the suggested changes, since we need to fix the react warning.

paranoidjk commented 7 years ago

@derpoho or i can open a another PR after you merge this

derpoho commented 7 years ago

@paranoidjk I can't merge it, i have no rights in this Repo, you must ask @JedWatson ;)

afc163 commented 7 years ago

I don't think this is still maintained, maybe we should maintain a forked version? @paranoidjk

paranoidjk commented 7 years ago

@afc163

Ok, i will fork this repo to react-component group and continue to mantain it.

still, thanks for @JedWatson great job.

JedWatson commented 7 years ago

Just FYI - I've been away for personal reasons but am picking this up at the moment and getting it ready for react 16, plus merging some other fixes.

@afc163 @paranoidjk I don't mind if you want to continue to maintain a fork, but you're welcome to help maintain this one if you like, just let me know.

stefanbackor commented 7 years ago

Any progress on this guys?

paranoidjk commented 7 years ago

@JedWatson 💯 Since our project https://ant.design/ is heavily rely on hammerjs, so I'd like to help with mantain this one.

If you agree with this, please add me owner permission, both my github and npm id is paranoidjk, email is hust2012jiangkai@gmail.com, thanks.

our fork is https://github.com/react-component/react-hammerjs

ibc commented 7 years ago

@JedWatson, I do not mean to hurry but any idea when this PR will be merged and a new NPM version will be available?

stefanbackor commented 7 years ago

Hey guys, this should do the work. https://github.com/JedWatson/react-hammerjs/pull/74

chadams commented 7 years ago

I removed the statics, is thats what is holding this up?

wwqrd commented 7 years ago

@chadams Did you ever find out?

jrsinclair commented 7 years ago

If I understand correctly, what's holding this up is that prop-types needs to be moved in package.json from devDependencies to dependencies. Can anyone confirm this?

synaestheory commented 7 years ago

@chadams @jrsinclair The move from devDependencies to dependencies is the only comment on the PR where changes were requested. I would guess that's all that's holding this up.

wwqrd commented 7 years ago

Looks like a version with the amends has already been posted here: #74

jrsinclair commented 7 years ago

This just became slightly more pressing, now that React 16 has been released.

jrsinclair commented 7 years ago

Was this PR made redundant by #78?

JedWatson commented 7 years ago

There were a bunch of issues with this in the end, I've cleaned it up significantly and replaced the build system so it should be good now. Try using 1.0.1