JedWatson / react-select

The Select Component for React.js
https://react-select.com/
MIT License
27.63k stars 4.13k forks source link

fix: Unset enabled Input visibility #5618

Open petrkrulis opened 1 year ago

petrkrulis commented 1 year ago

Enabled Input should not have visibility: 'visible' settings. The goal is just to hide it when disabled and don't do anything special when Input is in enabled state.

Visibility is one of those CSS props, which can override parent's settings. It doesn't behave the same as display would. Therefore, you cannot effectively hide it.

Example:

<div style={{visibility: 'hidden'}}> 
    <div style={{visibility: 'visible'}}>
        This is visible. Child style overrides parent style. 
    </div> 
</div> 

Solution is to use the unset value.

changeset-bot[bot] commented 1 year ago

⚠️ No Changeset found

Latest commit: 0dadb41449ff3d9a9cbdf6557f6a1697d3091acb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

codesandbox-ci[bot] commented 1 year ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0dadb41449ff3d9a9cbdf6557f6a1697d3091acb:

Sandbox Source
react-codesandboxer-example Configuration