search

JedWatson / react-select

The Select Component for React.js
https://react-select.com/
MIT License
27.63k stars 4.13k forks source link

fix: Option component innerRef type #5656

Open mihkeleidast opened 1 year ago

mihkeleidast commented 1 year ago

Two main considerations here:

  1. The issue with using RefCallback is that it does not accept null, which is a very common value when propagating refs in React components. I specifically ran into an type issue while trying to use floating-ui's useMergeRefs hook, which can return null in some scenarios.
  2. All other subcomponents already use Ref instead of RefCallback, so this improves consistency.
changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: c4dca1f01ac7175cbb801eb3ace4831f340b2a43

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------------ | ----- | | react-select | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codesandbox-ci[bot] commented 1 year ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c4dca1f01ac7175cbb801eb3ace4831f340b2a43:

Sandbox Source
react-codesandboxer-example Configuration