JedWatson / react-select

The Select Component for React.js
https://react-select.com/
MIT License
27.55k stars 4.12k forks source link

fix: support aria-placeholder #5657

Open seanlaff opened 1 year ago

seanlaff commented 1 year ago

The docs (https://react-select.com/props) define aria-placeholder as a supported prop, but as far as I could tell it wasn't actually supported. This changeset adds it.

Use case: I want to use page.getPlaceholder("Select foobar...") in playwright tests.

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: decabeb415f7cd1ae1031c9b694fa50a61892674

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------------ | ----- | | react-select | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codesandbox-ci[bot] commented 1 year ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit decabeb415f7cd1ae1031c9b694fa50a61892674:

Sandbox Source
react-codesandboxer-example Configuration
seanlaff commented 1 year ago

Not sure why the e2e tests timed out- I was going to retry the pipeline but I don't have permission

seanlaff commented 1 year ago

@Methuselah96 Would you be able to re-run this pipeline for me to see if the e2e timeout resolves itself?