JedWatson / react-select

The Select Component for React.js
https://react-select.com/
MIT License
27.54k stars 4.12k forks source link

fix: lack of disabled attribute on select element causing color contrast issue #5666

Closed yhy-1 closed 11 months ago

yhy-1 commented 1 year ago

As stated in this issue: https://github.com/JedWatson/react-select/issues/5550

"disabled" is properly set in the input, since it was used instead of aria-disabled, the lack of "aria-disabled" resulted in the automated a11y tool not determining it disabled element and cause a contrast issue.

Ref: UIEN-3643

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: fb4f8b473817e752370d0b3561e56010994f70f9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------------ | ----- | | react-select | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codesandbox-ci[bot] commented 1 year ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit fb4f8b473817e752370d0b3561e56010994f70f9:

Sandbox Source
react-codesandboxer-example Configuration
yhy-1 commented 1 year ago

@jjuradok @AriPerkkio @JedWatson Hi, is there any maintainer who can review this PR, please?

CC: @mellis481

mellis481 commented 1 year ago

This is a glaring a11y failure (WCAG 1.4.3) that my team is very much hoping can get merged and released soon.

edmilicich commented 1 year ago

@jjuradok lo va a ver, tranqui

yhy-1 commented 1 year ago

@jjuradok, @AriPerkkio @Rall3n @Methuselah96 @craigdallimore @jacobsfletch @oscarjg @gwyneplaine Any new update?

yhy-1 commented 12 months ago

@lukebennett88, @Methuselah96 Hi, are you able to look at this and get a merge or a list of approving reviews with write access?

yhy-1 commented 11 months ago

@JedWatson Hi is there anyone who can approve PR ?