search

JedWatson / react-select

The Select Component for React.js
https://react-select.com/
MIT License
27.49k stars 4.12k forks source link

Issue #5733: MenuPlacer useLayoutEffect depend on isLoading #5736

Open labkey-nicka opened 12 months ago

labkey-nicka commented 12 months ago

Fixes #5733. This PR passes the isLoading prop down to the MenuPlacer component and then relies on isLoading as a dependency for running the useLayoutEffect to recompute the position of the menu. Subsequently, getMenuPlacement will recalculate the menu's position.

changeset-bot[bot] commented 12 months ago

⚠️ No Changeset found

Latest commit: 7fe2092f532250cd9e6c7d98737784bfa5aa4e7a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

codesandbox-ci[bot] commented 12 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7fe2092f532250cd9e6c7d98737784bfa5aa4e7a:

Sandbox Source
react-codesandboxer-example Configuration
strange-chandrasekhar-lcxsh4 Issue #5733
labkey-nicka commented 11 months ago

Hi @Methuselah96, I'd like to put this PR on your radar for approval. Thanks!

labkey-nicka commented 11 months ago

Hello, is there something more I can do to get a reviewer to take a look at this PR? I see that there isn't much activity on this repository/package. Thanks.

labkey-nicka commented 10 months ago

Hey there, pinging this PR again in the hopes that someone is able to take a moment to triage/review. I appreciate it.

labkey-nicka commented 8 months ago

Should I continue to ping on this or just close it? Is react-select accepting changes?

thanhpd commented 8 months ago

@labkey-nicka The dev team is slow in this aspect. I'd say keep the PR open but do some workaround on your end in the meantime. I've used patch-package or yarn 3 to patch them silently for my projects.