JedWatson / react-select

The Select Component for React.js
https://react-select.com/
MIT License
27.49k stars 4.12k forks source link

Fix onTouchEnd target when in a shadow root #5737

Open rgripper opened 12 months ago

rgripper commented 12 months ago

For any element inside a shadow root event.target points to the shadow root, so a blur event is always evaluated to be outside of the select element. That means the dropdown opens on a touch start and mistakenly closes when the touch ends.

changeset-bot[bot] commented 12 months ago

⚠️ No Changeset found

Latest commit: 8dafd05ddf4152d08f7145a27aa3511c00e6232d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

codesandbox-ci[bot] commented 12 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8dafd05ddf4152d08f7145a27aa3511c00e6232d:

Sandbox Source
react-codesandboxer-example Configuration