JedWatson / react-select

The Select Component for React.js
https://react-select.com/
MIT License
27.63k stars 4.13k forks source link

Styles not Loading in Remix #5937

Open justinhandley opened 3 months ago

justinhandley commented 3 months ago

Hi There - I'm sorry, I'm not sure how to replicate this in your code sandbox. I have a suspicion that this somehow relates to Remix and SSR, but can't get to the root of it.

Basically, the form, doesn't display properly. If you change something in code, and dev mode reloads the page, then everything shows correctly. If you do an actual browser load or refresh, the form styles don't load correctly.

Screenshot 2024-07-22 at 12 42 13 PM

Based on my research, I have tried waiting for hydration, and I've tried using a useEffect to make sure it only loads in the client to separate from SSR, but neither works.

This is the controlled form field that I'm rendering:

import { useQuery } from '@apollo/client'
import { Control, Controller, FieldValues } from 'react-hook-form'
import AsyncSelect from 'react-select/async'
import { CSSObjectWithLabel, GroupBase, OptionsOrGroups } from 'react-select'

interface OptionType {
  label: string
  value: string
}

interface OptionItem {
  id: string
  name?: string
  firstName?: string
  lastName?: string
}

interface RelationSelectProps {
  field: {
    key: string
    options: {
      document?: any // Specify the GraphQL document type if available
      dataType?: string
      filter?: (items: OptionItem[]) => OptionItem[]
      selectOptionsFunction?: (items: OptionItem[]) => OptionType[]
      multi?: boolean
    }
  }
  control: Control<FieldValues, unknown>
}

function label(item: { id: string; name?: string; firstName?: string; lastName?: string }): string {
  if (item?.name) {
    return item.name
  }
  if (item?.firstName && item?.lastName) {
    return `${item.firstName} ${item.lastName}`
  }
  if (item?.firstName && !item?.lastName) {
    return item.firstName
  }
  return item.id
}

function defaultOptionsMap(items: OptionItem[]): OptionType[] {
  return items?.map?.((option) => ({ value: `${option.id}`, label: label(option) }))
}

export function RelationSelect({ field, control }: Readonly<RelationSelectProps>) {
  const { data, loading, refetch } = useQuery(field.options.document)

  let dataList: OptionItem[] =
    field.options.dataType && !loading ? data?.[field.options.dataType] : [{ value: '', label: 'Loading...' }]

  if (field.options.filter && !loading) {
    dataList = field.options.filter(dataList)
  }

  function getDefaultOptions(
    dataList: any[],
    options: { selectOptionsFunction?: (data: any[]) => OptionType[] },
  ): OptionType[] {
    if (dataList && dataList.length > 0) {
      if (options.selectOptionsFunction) {
        return options.selectOptionsFunction(dataList)
      } else {
        return defaultOptionsMap(dataList)
      }
    } else {
      return [{ value: '', label: 'No Matching Data Found' }]
    }
  }

  async function getStorageOptions(inputText: string): Promise<OptionsOrGroups<OptionType, GroupBase<OptionType>>> {
    const res = await refetch({ input: { search: inputText } })
    const data = field.options.dataType ? res.data[field.options.dataType] : null
    return getOptions(data)
  }

  function getOptions(data: any): OptionType[] | OptionsOrGroups<OptionType, GroupBase<OptionType>> {
    if (data) {
      if (field.options.selectOptionsFunction) {
        return field.options.selectOptionsFunction(data)
      } else {
        return defaultOptionsMap(data)
      }
    } else {
      return [{ value: '', label: 'No Matching Data Found' }]
    }
  }

  const customStyles = {
    control: (provided: CSSObjectWithLabel) => ({
      ...provided,
      backgroundColor: 'white',
      fontSize: '14px',
    }),
    singleValue: (provided: CSSObjectWithLabel) => ({
      ...provided,
      fontSize: '14px',
      color: '#64748b',
    }),
    option: (provided: CSSObjectWithLabel) => ({
      ...provided,
      fontSize: '14px',
      color: '#64748b',
    }),
  }

  return (
    <Controller
      control={control}
      name={field.key}
      render={({ field: { onChange, value } }) => (
        <AsyncSelect
          name={field.key}
          instanceId={field.key}
          value={value}
          key={field.key}
          defaultOptions={getDefaultOptions(dataList, field.options)}
          loadOptions={getStorageOptions}
          onChange={onChange}
          isLoading={loading}
          isMulti={field.options.multi}
          classNamePrefix="rs"
          styles={customStyles}
        />
      )}
    />
  )
}
TheAlexPorter commented 3 months ago

I'm in the same boat. There are a few similar issues open. I'm going to attempt the solution here in https://github.com/JedWatson/react-select/issues/3309#issuecomment-914446586 and see if by making each component with my own styles manually applied I can get past the issue.

Others:

https://github.com/JedWatson/react-select/issues/5710

https://github.com/JedWatson/react-select/issues/3680

TheAlexPorter commented 3 months ago

Update: I tried the method here where you add an emotion provider and that did the trick! Wrapping my app with a CacheProvider is all I had to do.

I don't like that I had to add an extra provider for styling I'm not using directly, but this beats the pain of having to migrate away from react-select.

Here is the snippet from my remix app:

// root.tsx

import createCache from '@emotion/cache'
import { CacheProvider } from '@emotion/react'

function AppWithProviders() {
    const data = useLoaderData<typeof loader>()
    const cache = createCache({
        key: 'test',
        prepend: false,
    })

    return (
        <HoneypotProvider {...data.honeyProps}>
            <CacheProvider value={cache}>
                <UserDataProvider
                    data={{
                        user: data.user,
                        theme: data.requestInfo.userPrefs.theme,
                    }}
                >
                    <App />
                </UserDataProvider>
            </CacheProvider>
        </HoneypotProvider>
    )
}

From this Isssue: https://github.com/JedWatson/react-select/issues/3680#issuecomment-924248517

I hope this helps!

justinhandley commented 3 months ago

Hey @TheAlexPorter - thanks so much for that - I did try wrapping the whole root of my app in an emotion provider and it didn't seem to have any effect. Is there anything else that you had to do to make this work? Do I have to consume the provider somewhere?

TheAlexPorter commented 3 months ago

I don't do anything other than wrap my app with the cache provider 🤔 The only other thing I did before attempting these solutions was upgrade react to 18.3.1 and remix-run to 2.10.3

grohart commented 3 months ago

Same problem here with Astro JS (strangely, it's working well in my Remix projects), when using Astro with ViewTransitions component in the page layout headers, styles of react-select are broken when navigating to another page and going back to the page where react-select is called

vemonet commented 3 weeks ago

That's the problem with those react projects relying on overly complex dependencies like emotion for doing super simple things like basic styling, it gets really unstable over time

I have a hard time to see how you even need this emotion dependency here, when you have perfectly fine web standards for defining styles that does not requires overly complex dependencies that breaks all over the place + you have JSX to make it conditional

Behavior is not even consistent... In our case on remix it works sometimes, sometimes it does not, depending on the browser and how you access the page (direct reload vs coming from another page).

Always try to keep it simple and low in dependencies!

And from the number of issues + PR this project does not really seems really maintained (which is understandable). And regarding number of issues + PRs + frequencies or recent commits emotion is also not maintained anymore. So this project is now condemned to not work in the future due to its heavy dependencies

Now I guess we just need to rewrite this select component directly. Good thing it's quite basic, it will not take much time but yeah, remember to always try to use web standards instead of overly complex dependencies for simple things like applying styles...

wowawiwa commented 3 weeks ago

On my end, React Select can work / not work depending on: 1) Browser extension: In dev, on Firefox, having Bitwarden extension makes the problem appear. Disabling Bitwarden fixes the problem. 2) In production, even with Bitwarden disabled, the problem is there.

This repository shows a minimal setup where I only created a new Remix app and installed React Select, and you can see it failing in Firefox with the Bitwarden extension.

wowawiwa commented 3 weeks ago

I got it clearer: