search

JedWatson / react-tappable

Tappable component for React
http://jedwatson.github.io/react-tappable/
MIT License
862 stars 90 forks source link

Fix `isMounted` deprecation #111

Closed matthieuprat closed 7 years ago

matthieuprat commented 7 years ago

As of React 15.5, isMounted is deprecated.

This changeset is based on React's own isMounted implementation: https://github.com/facebook/react/blob/v15.6.1/addons/create-react-class/factory.js#L695-L705

Fixes #105.

matthieuprat commented 7 years ago

Any news on this?

dcousens commented 7 years ago

@markoshust merged, but I can't release.

Or maybe I can. Released v1.0.1

markshust commented 7 years ago

It looks like v1.0.1 was released, but still getting the Warning: Tappable: isMounted is deprecated. error on that version.

dcousens commented 7 years ago

@markoshust thanks for the heads up, re-published as v1.0.2, ran npm run build this time.

markshust commented 7 years ago

Thank you, 1.0.2 works :)