search

JedWatson / react-tappable

Tappable component for React
http://jedwatson.github.io/react-tappable/
MIT License
862 stars 90 forks source link

Combination with Swiper #19

Closed KeKs0r closed 9 years ago

KeKs0r commented 9 years ago

Hi,

I am using touchstone in combination with swiper.js for some swipable subnavigation. I have experienced the problem that on one screen with Tochstone.Link and a swiper screen the combination is causing issues. If I want to initiate a swipe, but start it on a link, I can finish the swipe but the "tap" event is still triggered and I am navigated to the Link target, instead of the swipe target. I know that the tap is aborted when I scroll, but the swipe is not interrupting the tap. I am not sure if this issue can be addressed in react-tappable or If I need to manually write something.

JedWatson commented 9 years ago

We could fix this by allowing custom handlers to cancel the tap event. Can you post some code I can test against?

KeKs0r commented 9 years ago

Hi,

I have also an issue open on touchstone itself. I would be glad to support you guys in order to make an integration with swiper.js more smooth:

This is the basic gist I made for both: https://gist.github.com/KeKs0r/d2d9aaf625f991415196

Related issue can be found here: https://github.com/JedWatson/touchstonejs/issues/49

KeKs0r commented 9 years ago

I have now created a manual workaround by creating my own Link element. This link element takes an additional function as property which then checks if the action should be executed:

My Solution: https://gist.github.com/KeKs0r/74f7f2fcc53061a33d38

If anything similar could be integrated into tappable or Touchstone I would be glad. I am also interested in your feedback on the approach.