search

JedWatson / react-tappable

Tappable component for React
http://jedwatson.github.io/react-tappable/
MIT License
862 stars 90 forks source link

Remove Styles #31

Closed jossmac closed 9 years ago

jossmac commented 9 years ago

The consumer app should decide how to handle touch styles

dcousens commented 9 years ago

LGTM. @JedWatson this is a breaking change (but likely not terrible).

JedWatson commented 9 years ago

I'm not a fan. At the moment for anyone who uses Tappable, it "just works". This breaks that, and I'm not seeing a compelling reason for it. Anyone using tappable is going to have to work this out and update their stylesheets, which is not a small impact.

Happy to introduce an override in the future but right now it's a pretty big breaking change, I don't want to do that without a strong argument for.