search

JedWatson / react-tappable

Tappable component for React
http://jedwatson.github.io/react-tappable/
MIT License
862 stars 90 forks source link

Simplify classes and propTypes #32

Closed jossmac closed 9 years ago

jossmac commented 9 years ago

See the commits, they're pretty granular

dcousens commented 9 years ago

@jossmac any chance you could just use the classnames component here and avoid all this concatenation?

JedWatson commented 9 years ago

Also not going to merge this one, it's a major breaking change that would require stylesheet refactoring for anyone using these classes. Let's wait until we have a better reason for breaking things before we reintroduce this.