search

JedWatson / react-tappable

Tappable component for React
http://jedwatson.github.io/react-tappable/
MIT License
863 stars 90 forks source link

Fixes React 15.x warnings #81

Closed davidbyttow closed 8 years ago

davidbyttow commented 8 years ago

This is related to 78823031988808a4fdbcd9d3addff44892b4c9b6 except it makes the change in src

ianwith commented 8 years ago

👍 @JedWatson

Leechael commented 8 years ago

Dude, you forgot dist/ directory.

My version:

https://github.com/Leechael/react-tappable/commit/a1720ed2edea7755cb1894531d781332c8627589

cmswalker commented 8 years ago

Yeah regarding @Leechael it looks like the npm build script wasn't run after this merge was accepted in order to build the new dist/

Rob-ot commented 8 years ago

Thanks @Leechael, your version is working for now!

JedWatson commented 8 years ago

Oops, sorry this took me so long to review and get back to!

Original PR was against /lib which was overwritten by the build script that's run when I publish, this should resolve it. Thanks @guitardave24!

stoikerty commented 8 years ago

The errors are still coming up. https://github.com/JedWatson/react-tappable/issues/79#issuecomment-241268390

@JedWatson Is it possible to re-build and re-publish?

skystebnicki commented 8 years ago

After a fresh install I am seeing this error too. If it has been fixed then it has not been published to npm yet.