search

JedWatson / react-tappable

Tappable component for React
http://jedwatson.github.io/react-tappable/
MIT License
863 stars 90 forks source link

Props not removed from newComponentProps in lib code #83

Closed MarkRausch closed 8 years ago

MarkRausch commented 8 years ago

In src/getComponent, the properties activeDelay, classBase, and handlers are deleted from the newComponentProps object: https://github.com/JedWatson/react-tappable/blob/master/src/getComponent.js#L52-L55

However in lib/getComponent, those lines are missing and the 3 properties are left on newComponentProps: https://github.com/JedWatson/react-tappable/blob/master/lib/getComponent.js#L56-L66

We just updated to React version 15.3.0 and are getting the following warning because those properties aren't removed: bundle.js:1072 Warning: Unknown propsactiveDelay,classBase,handlerson <span> tag. Remove these props from the element. For details, see https://fb.me/react-unknown-prop in span (created by Tappable) in Tappable (created by Hotspots)

ianwith commented 8 years ago

@JedWatson This PR did not solve the problem. Still warning here. Forgot to run updating build?

KevisLuo commented 8 years ago

@JedWatson This warning marks me crazy!!!