search

JedWatson / react-tappable

Tappable component for React
http://jedwatson.github.io/react-tappable/
MIT License
862 stars 90 forks source link

Bypass setTimeout when activation should happen immediately #86

Closed Andorbal closed 7 years ago

Andorbal commented 7 years ago

This should fix #73 because even with a zero timeout, setTimeout does not execute immediately. Without this change, setting activeDelay to zero (which is the default) still results in about a quarter second or so delay on my phone. The delay seems shorter on my desktop, but is still noticable.

dcousens commented 7 years ago

@Andorbal if you want this, please rebase without your compilation in the diff

edit: it'd be great if you could rebase this actually, I too notice #73 as a bug in my own applications

Andorbal commented 7 years ago

I'm at codemash right now, but I will either get to it tonight after sessions end or when I get back home.

Andorbal commented 7 years ago

Ok, I've got the built files removed from the PR. Let me know if I need to do anything else, thanks!

dcousens commented 7 years ago

LGTM, I'm going to wait on @JedWatson so I can get him to release 1.0.0 when this PR Is merged... https://github.com/JedWatson/react-tappable/issues/69