Jeeaaasus / youtube-dl

Automated yt-dlp Docker image
https://hub.docker.com/r/jeeaaasustest/youtube-dl/
MIT License
258 stars 33 forks source link

Changing to yt-dlp. #49

Closed Jeeaaasus closed 2 years ago

Jeeaaasus commented 2 years ago

A place for questions, feedback, discussion and issues in regards to the yt-dlp change.

Jeeaaasus commented 2 years ago

If you are using %(playlist_index) in your output format together with --playlist-reverse, the recommendation is to move to %(playlist_autonumber) and use --compat-options playlist-index instead. More details here.

Delver26 commented 2 years ago

I've been using the beta tag for the last few days now and it's working perfectly. I've also been using some yt-dlp specific arguments (--parse-metadata) and it's all working without issue. Thanks!

Jeeaaasus commented 2 years ago

Hey @Delver26 I really appreciate you taking the time to let me know! heads up, I pushed a new one recently. probably the last one before it goes to latest

dingho commented 2 years ago

@Jeeaaasus I'm also moving over from youtube-dl, and having some trouble getting my output format the same as I had it before.

My previous arguments from youtube-dl: --download-archive downloaded.txt --playlist-reverse -o "C:\Users\dingho\youtube-dl\download\%(uploader)s - S01E%(playlist_index)s - %(title)s.%(ext)s"

From yt-dlp: --download-archive downloaded.txt --playlist-start 1 --playlist-reverse -o "C:\Users\dingho\yt-dlp\download\%(uploader)s - S01E%(playlist_autonumber)03d - %(title)s"

I'm trying to download the latest videos from playlists, that haven't previously been downloaded, monitored in a file (yt-dlp -a watch.txt), however it seems when a new video is added to a playlist, it's name contains S01E001 again instead of a newer autonumber. Any suggestions?

Jeeaaasus commented 2 years ago

Hi @dingho! :) I'm not sure at all, but have you tried also using the --compat-options playlist-index arg mentioned in the thread above? Otherwise you could try using --compat-options youtube-dl

--compat-options OPTS Options that can help keep compatibility with youtube-dl or youtube-dlc configurations by reverting some of the changes made in yt-dlp. See "Differences in default behavior" for details

wsc96 commented 2 years ago

Seems that the pgrep command is no longer present in the docker image (neither is ps). Any suggestions for a suitable health check script to use within docker-compose.yml?

edit BTW, thanks for this awesome repository :) doing an install of props inside the container for the meantime but if you have any health check ideas I'd like to hear them.

Jeeaaasus commented 2 years ago

Hi there @wsc96! Thanks :)

I personally haven't felt the need to have health checking because of how simple the container is, it's basically just a script running, ending and then starting again. I wouldn't know what to check for a health indicator. What are you checking?

Health checking a process seems kinda pointless to me, S6 is just restarting them when they die. Like the main bash script runs yt-dlp and then waits the interval time and then dies and the S6 overlay starts it again. Checking if the webserver is alive is an option, but not everyone is going to want to have the webui running and currently it is not on by default. The only useful health check I can think of is checking if it has internet access and that the webserver is alive, if enabled. It would be great if there's a way to have yt-dlp test if the config is valid, but I don't think that's a thing and even then, doesn't really seem worth it.

Maybe I should add health check for internet access? or maybe someone have a smart idea for a useful health check? I'm open for it. :)

wsc96 commented 2 years ago

You're welcome.

So I've been simply doing a 'pgrep -fl youtube-dl.sh' as part of the health check. Very basic really and so probably doesn't provide a lot of value. I have some monitoring and alerting around containers that uses the container status health. I haven't been using the webserver.

I too would be interested if anyone else has something that adds a little more insight into the health.

Thanks again!