Jeeaaasus / youtube-dl

Automated yt-dlp Docker image
https://hub.docker.com/r/jeeaaasustest/youtube-dl/
MIT License
258 stars 33 forks source link

Ensure archive exists when editing. #69

Closed fpiesche closed 2 years ago

fpiesche commented 2 years ago

I've never worked with FastAPI before so I'm not sure if the get_archive() function or any of the calls within it need to be async as well... be good if you could check and/or clarify that?

Jeeaaasus commented 2 years ago

I tested and it works as expected! As for whether it needs to be async or not, I am unsure.. I'm still learning as this project goes on and it also doesn't need to be perfect.

The one change I want to see before I merge is to move the 'get_archive' function to right after the 'execute' function at the top for better readability. :) Otherwise 👍