search

Jeeaaasus / youtube-dl

Automated yt-dlp Docker image
https://hub.docker.com/r/jeeaaasustest/youtube-dl/
MIT License
258 stars 33 forks source link

WebUI: Mark the web ui port 8080 as exposed in the Dockerfile #71

Closed dotWee closed 2 years ago

dotWee commented 2 years ago

Some Docker applications would benefit from having the EXPOSED declaration, for example nginx-proxy/docker-gen and nginx-proxy/nginx-proxy.

The EXPOSED declaration itself has no influence on the functionality of the docker container, as explained in the official Dockerfile reference for EXPOSED:

The ´EXPOSE´ instruction informs Docker that the container listens on the specified network ports at runtime. You can specify whether the port listens on TCP or UDP, and the default is TCP if the protocol is not specified.

The ´EXPOSE´ instruction does not actually publish the port. It functions as a type of documentation between the person who builds the image and the person who runs the container, about which ports are intended to be published. To actually publish the port when running the container, use the ´-p´ flag on ´docker run´ to publish and map one or more ports, or the ´-P´ flag to publish all exposed ports and map them to high-order ports.

Jeeaaasus commented 2 years ago

Yeah sure that's a valid reason to expose the default webui port, simply didn't feel necessary before.

dotWee commented 2 years ago

@Jeeaaasus off topic - do you know about TheFrenchGhosty's Ultimate-YouTube-DL-Scripts-Collection? A somewhat standard (with 1.5k stars) for youtube-dl/yt-dlp arguments.

Maybe worth taking a look at.

(Also, thanks for sharing your work! Turns managing a personal youtube archive into a run-and-forget task!)

Jeeaaasus commented 2 years ago

@dotWee I did not. Very good resource indeed!

Thank you! ❤️ I couldn't find anything to satisfy my needs so I created it for myself, I am glad others also find it useful 😄